-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disableAutoFetch regression in the generic viewer #5371
Fix disableAutoFetch regression in the generic viewer #5371
Conversation
hmm, that's not really a regression by design (to enable incomplete file loading both disableStream=true and disableAutoFetch=true must be set), since enabling stream shall automatically disableAutoFetch. we have a confusion here with the options and this PR might be an acceptable solution. however it's better to see something like enumeration
|
Just thinking: if we let disableAutoFetch to disable stream, there is really no need in disableStream |
A valid point, that I completely overlooked, sorry about that! |
I see. Yeah we need to fix "disableStream=true and disableAutoFetch=true" thing for the generic viewer |
After PR 5263, setting `disableAutoFetch = true` in the generic viewer no longer works correctly, since the entire file loads even with `disableStream = true`.
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b2fd88de096a903/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b2fd88de096a903/output.txt Total script time: 1.00 mins Published
|
Fix disableAutoFetch regression in the generic viewer
After PR #5263, setting
disableAutoFetch = true
no longer works correctly (the entire file loads). This is a tentative patch that attempts to address that.